Merged
Conversation
Member
code-crusher
commented
Dec 26, 2025
code-crusher
commented
- fix race condition with the isUserInput flag
- API Streaming Failed to have retry button
- fix previous commands still show run/reject buttons
- better checkpoint handling
- feat: migrate KiloTaskHeader and TaskItem to use ReadOnlyChatText
- add chat renderer
MIGRATION CHANGES: - Update KiloTaskHeader.tsx to import and use ReadOnlyChatText component - Replace custom highlightText function calls with ReadOnlyChatText - Remove unused highlighting functions (highlightSlashCommands, highlightMentions, highlightText) - Update TaskItem.tsx to use ReadOnlyChatText for consistent text rendering - Remove unused highlight property from DisplayHistoryItem interface - Remove empty DisplayHistoryItem interface to fix linting warning LINTING FIXES: - Clean up unused imports (validateSlashCommand, mentionRegexGlobal, vscode) - Remove unused customModes variable in KiloTaskHeader - Remove unused Mention import in ChatRow.tsx - Remove unused imports in ChatTextArea.tsx (getIconForFilePath, getIconUrlByName, formatMentionChipParts, getFileIconForMention, valueToHtml) - Remove unused mentionRegex import in ReadOnlyChatText.tsx BENEFITS: - Provides better text formatting with HTML conversion and mention support - Maintains all existing styling and layout functionality - Improves code consistency across chat components - Eliminates custom highlighting logic in favor of established component
Contributor
ContextThis release (v4.205.0) focuses on stabilizing the chat interface and improving API resilience. It addresses race conditions in user input flags, enhances error recovery with retry mechanisms for streaming failures, and centralizes chat rendering logic to ensure UI consistency across the application. ImplementationThe update refactors Summary By MatterAI
🔄 What ChangedRelease v4.205.0. Implements API retry buttons for failed streams, fixes race conditions in input flags, and centralizes chat rendering via 🔍 Impact of the ChangeSignificantly improves user experience by providing recovery paths for API errors and ensuring a stable, consistent text rendering across chat history and headers. Reduces code duplication by migrating multiple components to a unified renderer. 📁 Total Files ChangedClick to Expand
🧪 Test Added/RecommendedRecommended
🔒 Security VulnerabilitiesN/A Screenshots
How to Test
Get in TouchN/A |
![matter-ai-bot[bot]](https://avatars.githubusercontent.com/in/474549?s=60&v=4){kind=small}
Comment on lines
+17
to
+52
| const mentionMapRef = useRef<Map<string, string>>(new Map()) | ||
|
|
||
| useEffect(() => { | ||
| const w = window as any | ||
| setMaterialIconsBaseUri(w.MATERIAL_ICONS_BASE_URI) | ||
| }, []) | ||
|
|
||
| // Build mention map similar to ChatTextArea | ||
| useEffect(() => { | ||
| mentionMapRef.current.clear() | ||
|
|
||
| // Add opened tabs to mention map | ||
| openedTabs | ||
| .filter((tab) => tab.path) | ||
| .forEach((tab) => { | ||
| const fullPath = "/" + tab.path | ||
| const segments = fullPath.split("/").filter(Boolean) | ||
| const filename = segments.pop() || fullPath | ||
| mentionMapRef.current.set(filename, fullPath) | ||
| }) | ||
|
|
||
| // Add file paths to mention map (excluding already added opened tabs) | ||
| filePaths | ||
| .map((file) => "/" + file) | ||
| .filter((path) => !openedTabs.some((tab) => tab.path && "/" + tab.path === path)) | ||
| .forEach((fullPath) => { | ||
| const segments = fullPath.split("/").filter(Boolean) | ||
| const filename = segments.pop() || fullPath | ||
| mentionMapRef.current.set(filename, fullPath) | ||
| }) | ||
| }, [filePaths, openedTabs]) | ||
|
|
||
| const htmlContent = useMemo(() => { | ||
| if (!value) return '<br data-plain-break="true">' | ||
| return valueToHtml(value, materialIconsBaseUri, mentionMapRef.current, customModes) | ||
| }, [value, materialIconsBaseUri, customModes]) |
Contributor
There was a problem hiding this comment.
🟡 Bug / Reactivity
Issue: mentionMapRef is not reactive. If filePaths or openedTabs change (e.g., user opens a new file), the htmlContent will not re-render to highlight the new file mentions because useMemo does not track ref mutations.
Fix: Use useMemo to derive mentionMap directly, ensuring htmlContent updates when dependencies change.
Impact: Ensures correct syntax highlighting for file mentions as the workspace context changes.
Suggested change
| const mentionMapRef = useRef<Map<string, string>>(new Map()) | |
| useEffect(() => { | |
| const w = window as any | |
| setMaterialIconsBaseUri(w.MATERIAL_ICONS_BASE_URI) | |
| }, []) | |
| // Build mention map similar to ChatTextArea | |
| useEffect(() => { | |
| mentionMapRef.current.clear() | |
| // Add opened tabs to mention map | |
| openedTabs | |
| .filter((tab) => tab.path) | |
| .forEach((tab) => { | |
| const fullPath = "/" + tab.path | |
| const segments = fullPath.split("/").filter(Boolean) | |
| const filename = segments.pop() || fullPath | |
| mentionMapRef.current.set(filename, fullPath) | |
| }) | |
| // Add file paths to mention map (excluding already added opened tabs) | |
| filePaths | |
| .map((file) => "/" + file) | |
| .filter((path) => !openedTabs.some((tab) => tab.path && "/" + tab.path === path)) | |
| .forEach((fullPath) => { | |
| const segments = fullPath.split("/").filter(Boolean) | |
| const filename = segments.pop() || fullPath | |
| mentionMapRef.current.set(filename, fullPath) | |
| }) | |
| }, [filePaths, openedTabs]) | |
| const htmlContent = useMemo(() => { | |
| if (!value) return '<br data-plain-break="true">' | |
| return valueToHtml(value, materialIconsBaseUri, mentionMapRef.current, customModes) | |
| }, [value, materialIconsBaseUri, customModes]) | |
| const mentionMap = useMemo(() => { | |
| const map = new Map<string, string>() | |
| // Add opened tabs to mention map | |
| openedTabs | |
| .filter((tab) => tab.path) | |
| .forEach((tab) => { | |
| const fullPath = "/" + tab.path | |
| const segments = fullPath.split("/").filter(Boolean) | |
| const filename = segments.pop() || fullPath | |
| map.set(filename, fullPath) | |
| }) | |
| // Add file paths to mention map (excluding already added opened tabs) | |
| filePaths | |
| .map((file) => "/" + file) | |
| .filter((path) => !openedTabs.some((tab) => tab.path && "/" + tab.path === path)) | |
| .forEach((fullPath) => { | |
| const segments = fullPath.split("/").filter(Boolean) | |
| const filename = segments.pop() || fullPath | |
| map.set(filename, fullPath) | |
| }) | |
| return map | |
| }, [filePaths, openedTabs]) | |
| const htmlContent = useMemo(() => { | |
| if (!value) return '<br data-plain-break="true">' | |
| return valueToHtml(value, materialIconsBaseUri, mentionMap, customModes) | |
| }, [value, materialIconsBaseUri, mentionMap, customModes]) |
Contributor
|
✅ Reviewed the changes: Verified the cleanup in |
Contributor
|
Note PR Review SkippedPR review skipped as no relevant changes found due to large diff hunk OR part of a non-reviewable file. 📄Files skipped in review
💡Tips to use MatterAICommand List
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.